-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify how extension code for windows
crate works
#3110
Merged
kennykerr
merged 12 commits into
microsoft:master
from
sivadeilra:user/ardavis/includes
Jun 18, 2024
Merged
Simplify how extension code for windows
crate works
#3110
kennykerr
merged 12 commits into
microsoft:master
from
sivadeilra:user/ardavis/includes
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
previously approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Nice to see a ton of duplicated code and hardcoded lists disappear.
kennykerr
reviewed
Jun 18, 2024
kennykerr
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the complexity between
windows-bindgen
andwindows
. This makes it much easier to write "extension" code for thewindows
crate, by reducing the number of places in the code you need to touch.This also removes the need to run
cargo run -p tool_bindings
whenever you touch the extension code for thewindows
crate. You don't need to update the bindings if you're just working on the extensions. Instead, you just edit extension code, like normal Rust code.The extension code has moved from
.../bindgen/src/rust/extensions
towindows/src/extensions
. This puts the code much closer to the code that it extends. Also, the extension code is now just a normal set of Rust modules. This makes the language service (Rust Analyzer) work more naturally; refactoring and go-to-definition and such simply work, rather than pointing to source files that were generated bybindgen
.Since the extension code is now just normal Rust modules, I had to add a handful of
use crate::Foo::Bar::BAZ;
imports to each extension source file. This seems like a good thing; more signs that this is just normal code.I've staged the changes in a set of commits. You can see how each piece of extension logic was moved, or you can view all the changes as a single set. The last commit applies
rustfmt
to the extension code. This wasn't happening before, since those files were not part of any module tree, socargo fmt
overlooked them.